[webkit-reviews] review denied: [Bug 134351] [Win] Fix potential buffer overrun in DLLLauncher : [Attachment 233915] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Brent Fulgham <bfulgham at webkit.org>'s
request for review:
Bug 134351: [Win] Fix potential buffer overrun in DLLLauncher
https://bugs.webkit.org/show_bug.cgi?id=134351

Attachment 233915: Patch
https://bugs.webkit.org/attachment.cgi?id=233915&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=233915&action=review


> Tools/win/DLLLauncher/DLLLauncherMain.cpp:177
>      if (len >= bufSize)
> -	   len = bufSize - 1;
> +	   len = bufSize - 2;

This change looks wrong.

> Tools/win/DLLLauncher/DLLLauncherMain.cpp:179
>      errorMessage[len + 1] = 0;

This is the line of code that seems to have a bug. It should say
errorMessage[len] = '\0';