[webkit-reviews] review granted: [Bug 134352] [MSE] Refactoring: Use C++11 for-loops in SourceBuffer. : [Attachment 233918] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 26 11:35:36 PDT 2014


Darin Adler <darin at apple.com> has granted Jer Noble <jer.noble at apple.com>'s
request for review:
Bug 134352: [MSE] Refactoring: Use C++11 for-loops in SourceBuffer.
https://bugs.webkit.org/show_bug.cgi?id=134352

Attachment 233918: Patch
https://bugs.webkit.org/attachment.cgi?id=233918&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=233918&action=review


> Source/WebCore/Modules/mediasource/SourceBuffer.cpp:316
> +	   AtomicString trackID = trackBufferPair.key;

Wasting a little performance here by using AtomicString instead of const
AtomicString& or auto&.


More information about the webkit-reviews mailing list