[webkit-reviews] review granted: [Bug 134620] Teach check-webkit-style to suggest WTF::move() when it sees std::move() : [Attachment 234383] Patch and unit test

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 134620: Teach check-webkit-style to suggest WTF::move() when it sees
std::move()
https://bugs.webkit.org/show_bug.cgi?id=134620

Attachment 234383: Patch and unit test
https://bugs.webkit.org/attachment.cgi?id=234383&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=234383&action=review


Nice! r=me

> Tools/Scripts/webkitpy/style/checkers/cpp.py:2286
> +    # This check doesn't apply to C or Objective-C implementation files.
> +    if file_state.is_c_or_objective_c():
> +	   return

We want this for ObjC++. This "is_c_or_objective_c" to too generic for that. A
quick search found:

  network/ios/QuickLook.mm
  431:	  return WTF::move(quickLookHandle);
  445:	  return WTF::move(quickLookHandle);
  463:	  return WTF::move(quickLookHandle);

Maybe we would want an "is_cpp".