[webkit-reviews] review granted: [Bug 134613] When showing the selection menu, include menu options for all selected phone numbers : [Attachment 234382] Patch v3
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jul 3 17:35:08 PDT 2014
Tim Horton <thorton at apple.com> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 134613: When showing the selection menu, include menu options for all
selected phone numbers
https://bugs.webkit.org/show_bug.cgi?id=134613
Attachment 234382: Patch v3
https://bugs.webkit.org/attachment.cgi?id=234382&action=review
------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=234382&action=review
> Source/WebCore/English.lproj/Localizable.strings:122
> +"Call â%@â Using iPhone" = "Call â%@â Using iPhone";
Sam/Dan/Anders have vetoed my objection to this, so I guess it's ok :)
> Source/WebKit2/UIProcess/mac/WebContextMenuProxyMac.mm:408
> + NSMenuItem *item = menuItemForTelephoneNumber(telephoneNumber);
> + if (item)
merge these lines
More information about the webkit-reviews
mailing list