[webkit-reviews] review requested: [Bug 134616] Add more coverage for the profile_types_with_high_fidelity op code : [Attachment 234384] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jul 3 17:55:02 PDT 2014
Saam Barati <sbarati at apple.com> has asked for review:
Bug 134616: Add more coverage for the profile_types_with_high_fidelity op code
https://bugs.webkit.org/show_bug.cgi?id=134616
Attachment 234384: patch
https://bugs.webkit.org/attachment.cgi?id=234384&action=review
------- Additional Comments from Saam Barati <sbarati at apple.com>
More operations are now being recorded by the profile_types_with_high_fidelity
opcode. Specifically: function parameters, function return values,
function 'this' value, get_by_id, get_by_value, resolve nodes, function return
values at the call site. Added more flags to the
profile_types_with_high_fidelity
opcode so more focused tasks can take place when the instruction is
being linked in CodeBlock. Re-worked the type profiler to search
through character offset ranges when asked for the type of an expression
at a given offset. Removed redundant calls to Structure::toStructureShape
in HighFidelityLog and TypeSet by caching calls based on StructureID.
More information about the webkit-reviews
mailing list