[webkit-reviews] review denied: [Bug 126407] Set VSINSTALLDIR in win ews start script : [Attachment 220257] vcvarsall version

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has denied Roger Fong
<roger_fong at apple.com>'s request for review:
Bug 126407: Set VSINSTALLDIR in win ews start script
https://bugs.webkit.org/show_bug.cgi?id=126407

Attachment 220257: vcvarsall version
https://bugs.webkit.org/attachment.cgi?id=220257&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=220257&action=review


> Tools/EWSTools/start-queue-win.sh:25
> +	   cmd /c "$PROGRAMFILES\Microsoft Visual Studio 12.0\VC\vcvarsall.bat"


This should be "CALL "$PROGRAMFILES...."

We want the queue to run with the contents of the batch file added to the shell
environment.  The 'cmd' version will spawn a new shell, which will cease to
exist once the command finishes running.