[webkit-reviews] review denied: [Bug 126407] Set VSINSTALLDIR in win ews start script : [Attachment 220256] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jan 2 15:31:53 PST 2014
Brent Fulgham <bfulgham at webkit.org> has denied Roger Fong
<roger_fong at apple.com>'s request for review:
Bug 126407: Set VSINSTALLDIR in win ews start script
https://bugs.webkit.org/show_bug.cgi?id=126407
Attachment 220256: patch
https://bugs.webkit.org/attachment.cgi?id=220256&action=review
------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=220256&action=review
> Tools/EWSTools/start-queue-win.sh:25
> + export VSINSTALLDIR="$PROGRAMFILES\Microsoft Visual Studio 12.0"
I don't care for this version as much, because it doesn't set the other
environment variables (such as LIBPATH, etc.) which might be useful for
building.
More information about the webkit-reviews
mailing list