[webkit-reviews] review granted: [Bug 126409] CStack LLInt 32-bit should build : [Attachment 220260] the patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 2 15:27:48 PST 2014


Michael Saboff <msaboff at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 126409: CStack LLInt 32-bit should build
https://bugs.webkit.org/show_bug.cgi?id=126409

Attachment 220260: the patch
https://bugs.webkit.org/attachment.cgi?id=220260&action=review

------- Additional Comments from Michael Saboff <msaboff at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=220260&action=review


r=me, with comments.

> Source/JavaScriptCore/ChangeLog:8
> +	   

Description of what you did...

> Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm:165
>	   const extraStackSpace = 16

This line can be removed.

> Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm:177
>	   const extraStackSpace = 28

This line can be removed.


More information about the webkit-reviews mailing list