[webkit-reviews] review granted: [Bug 128995] Use std::swap() in HashTable::swap() : [Attachment 224544] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Feb 19 11:22:43 PST 2014
Brent Fulgham <bfulgham at webkit.org> has granted Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 128995: Use std::swap() in HashTable::swap()
https://bugs.webkit.org/show_bug.cgi?id=128995
Attachment 224544: Patch
https://bugs.webkit.org/attachment.cgi?id=224544&action=review
------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
It's nice to not reinvent the wheel! Thanks for catching this.
Do we know if this gives any tiny microptimization based on the compiler being
able to do moves instead of all of the copying? We probably don't measure
enough to tell.
More information about the webkit-reviews
mailing list