[webkit-reviews] review granted: [Bug 129024] Changing selection shouldn't synchronously update editor UI components : [Attachment 224595] Fixes Windows build

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 129024: Changing selection shouldn't synchronously update editor UI
components
https://bugs.webkit.org/show_bug.cgi?id=129024

Attachment 224595: Fixes Windows build
https://bugs.webkit.org/attachment.cgi?id=224595&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=224595&action=review


A couple of minor nits to consider, but r=me.

> Source/WebCore/testing/Internals.cpp:1318
> +    // FIXME: We shouldn't pollute the id namespace with this name.

Should we file a bug to track this FIXME?

> LayoutTests/platform/mac/editing/deleting/id-in-deletebutton.html:14
> +    shouldBeNonNull('internals.findEditingDeleteButton();
document.getElementById("WebKit-Editing-Delete-Button")');

I don't feel like this is clearer than the original code.