[webkit-reviews] review granted: [Bug 129004] UIProcess needs to know the color of the page's extended background : [Attachment 224561] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Beth Dakin <bdakin at apple.com>'s
request for review:
Bug 129004: UIProcess needs to know the color of the page's extended background
https://bugs.webkit.org/show_bug.cgi?id=129004

Attachment 224561: Patch
https://bugs.webkit.org/attachment.cgi?id=224561&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=224561&action=review


r=me

> Source/WebKit2/ChangeLog:8
> +	   New method on WKWebView and WKView will return the page’s extended
background 

Yuck. Looks like a non-ASCII apostrophe.

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:531
> +    return [UIColor colorWithRed:(color.red() / 255.0) green:(color.green()
/ 255.0) blue:(color.blue() / 255.0) alpha:(color.alpha() / 255.0)];

It's too bad we don't have a helper function for this, so that
WebCore::Color->UIColor is always done the same way.