[webkit-reviews] review granted: [Bug 31993] http://webkit.org/coding/coding-style.html should mention check-webkit-style : [Attachment 218051] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 19 09:21:55 PDT 2014

Darin Adler <darin at apple.com> has granted ezisfake
<Szanka.Peter at stud.u-szeged.hu>'s request for review:
Bug 31993: http://webkit.org/coding/coding-style.html should mention

Attachment 218051: Patch

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=218051&action=review

> Websites/webkit.org/coding/contributing.html:94
> +<p>Your patch will be automatically checked for style compliance before
uploading if you use webkit-patch upload.

This mention of webkit-patch upload here is not formatted the way the other
mentions in this document are.

> Websites/webkit.org/coding/contributing.html:95
> +You can do it manually with the check-webkit-style script and will be
checked always after uploading by <a

Grammar mistake here. It says:

    You can do it and will be checked

I would write something more like this:

    You can check style manually by running the
Tools/Scripts/check-webkit-style script. Style will also be checked on each
patch after it is uploaded by the <a
href="http://trac.webkit.org/wiki/EWS">WebKit Early Warning System</a>.

It’s a little strange to have a link to the wiki from this page. Normally we
don’t do that.

More information about the webkit-reviews mailing list