[webkit-reviews] review granted: [Bug 91742] check-webkit-style crashes with OSError exception if SVN is not installed : [Attachment 206523] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Emanuele Aina
<emanuele.aina at collabora.com>'s request for review:
Bug 91742: check-webkit-style crashes with OSError exception if SVN is not
installed
https://bugs.webkit.org/show_bug.cgi?id=91742

Attachment 206523: Patch
https://bugs.webkit.org/attachment.cgi?id=206523&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=206523&action=review


> Tools/Scripts/webkitpy/common/checkout/scm/svn.py:104
> +	       _log.warning("No `svn` executable found in $PATH, assume this is
not a Subversion repository.")

Not sure I understand the grammar here. Here’s the sentence:

    No executable found, assume this is not a repository.

It seems like a comma splice, and I don’t understand why the tool is telling me
to assume something.