[webkit-reviews] review denied: [Bug 121970] [WK2] Does not remove page from WebProcessProxy's map upon WebProcess termination : [Attachment 213185] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Gustavo Noronha (kov)
<gns at gnome.org>'s request for review:
Bug 121970: [WK2] Does not remove page from WebProcessProxy's map upon
WebProcess termination
https://bugs.webkit.org/show_bug.cgi?id=121970

Attachment 213185: Patch
https://bugs.webkit.org/attachment.cgi?id=213185&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=213185&action=review


> Source/WebKit2/UIProcess/WebPageProxy.cpp:364
> +	   // A page may not be closed but be invalid because the WebProcess
has exited; in that
> +	   // case close() will simply return, leaving the page registered on
WebProcessProxy's map,
> +	   // so we remove it here.
> +	   if (!isValid())
> +	       m_process->removeWebPage(m_pageID);
> +	   else
> +	       close();

The right place to fix this is in WebPageProxy::resetStateAfterProcessExited,
not here.