[webkit-reviews] review granted: [Bug 135807] generate header detection files on Windows CMake : [Attachment 236383] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 12 14:32:26 PDT 2014

Brent Fulgham <bfulgham at webkit.org> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 135807: generate header detection files on Windows CMake

Attachment 236383: Patch

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=236383&action=review

r=me. Please change those bugs to be "FIXME(Bug ###)" format, with bugs filed
to extend the CMake stuff to do what we need for internal use.

> Source/WTF/wtf/PlatformWin.cmake:22
> +#FIXME: This should run testOSXLevel.cmd if it is available.

Please file a bug and make this a #FIXME(Bug##) bug.

> Source/WebCore/PlatformWin.cmake:93
> +#FIXME: This should test if AVF headers are available.

Ditto above comment.

More information about the webkit-reviews mailing list