[webkit-reviews] review granted: [Bug 135682] Runtime switch for long mouse press gesture. Part of 135257 - Add long mouse press gesture : [Attachment 236468] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Peyton Randolph
<prandolph at apple.com>'s request for review:
Bug 135682: Runtime switch for long mouse press gesture. Part of 135257 - Add
long mouse press gesture
https://bugs.webkit.org/show_bug.cgi?id=135682

Attachment 236468: Patch
https://bugs.webkit.org/attachment.cgi?id=236468&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=236468&action=review


> Source/WebCore/page/EventHandler.cpp:1606
> +    if (!(page && page->settings().longMousePressEnabled()))

You still don't really need this because it's crazy to worry about the case
where the timer started and then the preference was turned off and then the
cancel comes through, but I don't really care either way.