[webkit-reviews] review denied: [Bug 135819] progress towards building WebCore with CMake on Mac : [Attachment 236464] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 12 14:38:50 PDT 2014

Brent Fulgham <bfulgham at webkit.org> has denied Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 135819: progress towards building WebCore with CMake on Mac

Attachment 236464: Patch

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=236464&action=review

I don't think this is quite right, since it breaks an existing port that relies
on CMake for its builds. Otherwise I think the general approach is good.

> Source/WebCore/CMakeLists.txt:-178
> -

Can these just be commented out with a FIXME(Bug ###) comment?

> Source/WebCore/PlatformMac.cmake:-146
> -    platform/mac/WebCoreView.m

Where did this go? Do we not have this file anymore?

> Source/WebCore/PlatformMac.cmake:-166
> -    platform/network/cf/ProtectionSpaceCFNet.cpp


> Source/WebCore/PlatformMac.cmake:-204
> -    plugins/mac/PluginViewMac.mm

Were these removed?

> Source/WebCore/bindings/scripts/CodeGeneratorObjC.pm:384
> +    die if $fatalError && $className ne "DOMAbstractView"; #
ObjCCustomImplementation doesn't work with CMake right now.

Can you make this a FIXME(Bug XXX) comment, please?

> Source/cmake/OptionsMac.cmake:212

You should have a FIXME(Bug XXX) here to remind you to turn these back on.

> Source/cmake/WebKitMacros.cmake:37
> +macro(GENERATE_BINDINGS _output_source _input_files _base_dir _idl_includes
_features _destination _prefix _generator _extension _idl_attributes_file)

This is causing the EFL build to fail. You need to add the 'cpp' target to
those CMake files.

More information about the webkit-reviews mailing list