[webkit-reviews] review granted: [Bug 130701] Web Inspector: reduce per-protocol method function creation in InspectorBackend : [Attachment 230415] the patch

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has granted Brian Burg
<burg at cs.washington.edu>'s request for review:
Bug 130701: Web Inspector: reduce per-protocol method function creation in
InspectorBackend
https://bugs.webkit.org/show_bug.cgi?id=130701

Attachment 230415: the patch
https://bugs.webkit.org/attachment.cgi?id=230415&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=230415&action=review


> Source/WebInspectorUI/UserInterface/Protocol/InspectorBackend.js:246
> +    var callable = function() {

function callable()
{

> Source/WebInspectorUI/UserInterface/Protocol/InspectorBackend.js:248
> +    };

No ;

> Source/WebInspectorUI/UserInterface/Protocol/InspectorBackend.js:292
> +	   console.log("invoke args: ", args, "len: ", args.length);
> +	   console.log("signature: ", JSON.stringify(instance._callSignature));


Debug? Or this.dumpInspectorProtocolMessages?

> Source/WebInspectorUI/UserInterface/Protocol/InspectorBackend.js:295
> +	   console.log("callback:", callback);

Ditto.

> Source/WebInspectorUI/UserInterface/Protocol/InspectorBackend.js:310
> +	       console.log("processing arg " + i + ":", value);

Ditto.

> Source/WebInspectorUI/UserInterface/Protocol/InspectorBackend.js:313
> +	       if (optionalFlag && typeof value === "undefined") {
> +		   continue;
> +	       }

No braces.