[webkit-reviews] review denied: [Bug 132361] [GTK] Update TestExpectations to unskip http/tests/media/hls : [Attachment 230428] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 29 15:23:04 PDT 2014


Martin Robinson <mrobinson at webkit.org> has denied  review:
Bug 132361: [GTK] Update TestExpectations to unskip http/tests/media/hls
https://bugs.webkit.org/show_bug.cgi?id=132361

Attachment 230428: Patch
https://bugs.webkit.org/attachment.cgi?id=230428&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=230428&action=review


> LayoutTests/ChangeLog:5
> +	   * platform/gtk/TestExpectations: Flagged some tests

This doesn't really describe what you are doing.

> LayoutTests/platform/gtk/TestExpectations:417
>  # No HLS support
> -http/tests/media/hls [ Skip ]
> +webkit.org/b/132329 http/tests/media/hls [ Failure ]

So the comment is now inaccurate? hls support exists now, these should be moved
to the section of the file that deals with unexpected failures.


More information about the webkit-reviews mailing list