[webkit-reviews] review granted: [Bug 132353] Remove some PLATFORM(IOS) #ifdefs related to hasAcceleratedTouchScrolling() : [Attachment 230427] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 132353: Remove some PLATFORM(IOS) #ifdefs related to
hasAcceleratedTouchScrolling()
https://bugs.webkit.org/show_bug.cgi?id=132353

Attachment 230427: Patch
https://bugs.webkit.org/attachment.cgi?id=230427&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=230427&action=review


> Source/WebCore/rendering/RenderLayerBacking.cpp:-412
> -// FIXME: We should merge the concept of
RenderLayer::{hasAcceleratedTouchScrolling, needsCompositedScrolling}()
> -// so that we can remove this iOS-specific variant.

Don’t we still want something like this FIXME?

> Source/WebCore/rendering/RenderLayerBacking.cpp:443
> +    return (style.transformOriginX().type() == Fixed &&
style.transformOriginX().value())
> +	   || (style.transformOriginY().type() == Fixed &&
style.transformOriginY().value());

I don’t think we need these parentheses.