[webkit-reviews] review granted: [Bug 132360] Don't hold on to BindingNodes forever : [Attachment 230429] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Oliver Hunt <oliver at apple.com>'s
request for review:
Bug 132360: Don't hold on to BindingNodes forever
https://bugs.webkit.org/show_bug.cgi?id=132360

Attachment 230429: Patch
https://bugs.webkit.org/attachment.cgi?id=230429&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=230429&action=review


r=me

> Source/JavaScriptCore/bytecode/UnlinkedCodeBlock.cpp:196
> +    // We make an isolated copy of the parameter string as we don't want to
keep the
> +    // full source string alive.
> +    String parameterString =
source.provider()->getRange(node->parametersStartOffset(),
node->parametersEndOffset()).isolatedCopy();

An executable always keeps its full source provider alive, so I don't think
isolatedCopy() is an improvement here.