[webkit-reviews] review requested: [Bug 108565] [CPP, GObject, ObjC] Add 'enum' skip to CodeGenerator{CPP, GObject, ObjC}.pm : [Attachment 185936] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 31 21:22:31 PST 2013


Nils Barth <nbarth at google.com> has asked  for review:
Bug 108565: [CPP,GObject,ObjC] Add 'enum' skip to
CodeGenerator{CPP,GObject,ObjC}.pm
https://bugs.webkit.org/show_bug.cgi?id=108565

Attachment 185936: Patch
https://bugs.webkit.org/attachment.cgi?id=185936&action=review

------- Additional Comments from Nils Barth <nbarth at google.com>
Simple patch -- adds IsEnumType test to SkipAttribute in legacy code generators
so we can remove #if macro from IDL test file.
Also minor associated code cleaning (b/c we're checking type):
aux var: $type = $attribute->signature->type
(is this ok?)


More information about the webkit-reviews mailing list