[webkit-reviews] review requested: [Bug 108431] webdatabase: Clean up calls to DatabaseTracker::add/removeOpenDatabase() : [Attachment 185935] the patch plus fixing up the chromium port to work with this change.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 31 21:19:52 PST 2013


Mark Lam <mark.lam at apple.com> has asked  for review:
Bug 108431: webdatabase: Clean up calls to
DatabaseTracker::add/removeOpenDatabase()
https://bugs.webkit.org/show_bug.cgi?id=108431

Attachment 185935: the patch plus fixing up the chromium port to work with this
change.
https://bugs.webkit.org/attachment.cgi?id=185935&action=review

------- Additional Comments from Mark Lam <mark.lam at apple.com>
Thanks to Michael for pointing out what the chromium port expects in terms of
when it needs databaseOpened() and databaseClosed() to be called.  I introduced
(for the Chromium port only) DatabaseTracker::prepareToOpenDatabase() and
DatabaseTracker::failedToOpenDatabase() which takes care of calling
databaseOpened() and databaseClosed() at the right time.  May I have a review
from the Chromium folks on these port specific changes please?


More information about the webkit-reviews mailing list