[webkit-reviews] review granted: [Bug 108565] [CPP, GObject, ObjC] Add 'enum' skip to CodeGenerator{CPP, GObject, ObjC}.pm : [Attachment 185936] Patch

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has granted Nils Barth
<nbarth at google.com>'s request for review:
Bug 108565: [CPP,GObject,ObjC] Add 'enum' skip to
CodeGenerator{CPP,GObject,ObjC}.pm
https://bugs.webkit.org/show_bug.cgi?id=108565

Attachment 185936: Patch
https://bugs.webkit.org/attachment.cgi?id=185936&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=185936&action=review


> Source/WebCore/ChangeLog:8
> +	   Add IsEnumType test to SkipAttribute in legacy code generators.

Please explain the rationale for the change, not only what you did but also why
you did it.

e.g. Since CodeGenerator{CPP,GObject,ObjC}.pm does not support 'enum', this
patch adds code to skip DOM attributes that return 'enum'.

> Source/WebCore/bindings/scripts/test/TestObj.idl:47
>      static readonly attribute long	  staticReadOnlyLongAttr;
>      static attribute DOMString	  staticStringAttr;
>      static readonly attribute TestSubObjConstructor TestSubObj;
> -    attribute TestEnumType		  enumAttr;
>  #endif

I think you can remove this #if too by skipping 'static' in
CodeGenerator{ObjC,GObject,CPP}.pm. You can do it in a follow-up patch.