[webkit-reviews] review granted: [Bug 120516] Resolve unused parameter warning in FindController.cpp : [Attachment 210079] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 30 08:00:49 PDT 2013


Darin Adler <darin at apple.com> has granted Tamas Czene
<tczene at inf.u-szeged.hu>'s request for review:
Bug 120516: Resolve unused parameter warning in FindController.cpp
https://bugs.webkit.org/show_bug.cgi?id=120516

Attachment 210079: proposed patch
https://bugs.webkit.org/attachment.cgi?id=210079&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=210079&action=review


> Source/WebKit2/WebProcess/WebPage/FindController.cpp:397
> +void FindController::drawRect(PageOverlay* /*pageOverlay*/, GraphicsContext&
graphicsContext, const IntRect& dirtyRect)

Should remove the argument name entirely. There is no information conveyed by a
commented-out name that repeats the type.


More information about the webkit-reviews mailing list