[webkit-reviews] review granted: [Bug 120407] Resolve unused parameter warning in WebKitAccessibleInterfaceText.cpp : [Attachment 210081] proposed patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Tamas Czene
<tczene at inf.u-szeged.hu>'s request for review:
Bug 120407: Resolve unused parameter warning in
WebKitAccessibleInterfaceText.cpp
https://bugs.webkit.org/show_bug.cgi?id=120407

Attachment 210081: proposed patch
https://bugs.webkit.org/attachment.cgi?id=210081&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=210081&action=review


> Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceText.cpp:715
> +static VisibleSelection wordAtPositionForAtkBoundary(const
AccessibilityObject* /*coreObject*/, const VisiblePosition& position,
AtkTextBoundary boundaryType)

You say “the name refers to its purpose”, but “core object” means nothing to
me. Core of what? What object? It’s not adding anything.