[webkit-reviews] review granted: [Bug 120515] Resolve unused parameter warning in WebPlatformStrategies.cpp : [Attachment 210078] proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Aug 30 08:00:14 PDT 2013
Darin Adler <darin at apple.com> has granted Tamas Czene
<tczene at inf.u-szeged.hu>'s request for review:
Bug 120515: Resolve unused parameter warning in WebPlatformStrategies.cpp
https://bugs.webkit.org/show_bug.cgi?id=120515
Attachment 210078: proposed patch
https://bugs.webkit.org/attachment.cgi?id=210078&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=210078&action=review
> Source/WebKit2/WebProcess/WebPage/TapHighlightController.cpp:100
> +void TapHighlightController::drawRect(PageOverlay* /*pageOverlay*/,
GraphicsContext& context, const IntRect& /*dirtyRect*/)
Should remove the argument entirely. No need for the commented out word
"pageOverlay"; it doesn’t document anything.
More information about the webkit-reviews
mailing list