[webkit-reviews] review granted: [Bug 97060] [V8] Remove WorkerContextExecutionProxy::runScript() : [Attachment 164645] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 19 11:30:44 PDT 2012


Adam Barth <abarth at webkit.org> has granted Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 97060: [V8] Remove WorkerContextExecutionProxy::runScript()
https://bugs.webkit.org/show_bug.cgi?id=97060

Attachment 164645: Patch
https://bugs.webkit.org/attachment.cgi?id=164645&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=164645&action=review


> Source/WebCore/bindings/v8/WorkerContextExecutionProxy.cpp:-274
> -    if (script.IsEmpty())
> -	   return v8::Local<v8::Value>();

This check is missing from ScriptRunner::runCompiledScript.  I guess its not
needed?


More information about the webkit-reviews mailing list