[webkit-reviews] review granted: [Bug 96567] [V8] ScriptController::compileAndRunScript() can crash : [Attachment 164640] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Sep 19 11:24:20 PDT 2012
Adam Barth <abarth at webkit.org> has granted Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 96567: [V8] ScriptController::compileAndRunScript() can crash
https://bugs.webkit.org/show_bug.cgi?id=96567
Attachment 164640: Patch
https://bugs.webkit.org/attachment.cgi?id=164640&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=164640&action=review
ok
> Source/WebCore/bindings/v8/ScriptSourceCode.cpp:53
> + if (!scriptData.get())
> + return nullptr;
There's no reason to call get() here. OwnPtr has a bool operator.
More information about the webkit-reviews
mailing list