[webkit-reviews] review denied: [Bug 97066] [V8] Move WorkerContextExecutionProxy::initIsolate() to WorkerScriptController : [Attachment 164655] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Kentaro Hara <haraken at chromium.org>'s
request for review:
Bug 97066: [V8] Move WorkerContextExecutionProxy::initIsolate() to
WorkerScriptController
https://bugs.webkit.org/show_bug.cgi?id=97066

Attachment 164655: Patch
https://bugs.webkit.org/attachment.cgi?id=164655&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=164655&action=review


> Source/WebCore/bindings/v8/V8Binding.cpp:362
> +    int memoryUsageMB = MemoryUsageSupport::actualMemoryUsageMB();

Is this function safe to call on a worker thread?  I guess we're just going to
CRASH() a couple lines later, but it seems like we should make sure the
threading is ok anyway.

> Source/WebCore/bindings/v8/WorkerScriptController.cpp:88
> +void WorkerScriptController::initIsolate()

This function looks very similar to initializeV8IfNeeded.  Should we move
initializeV8IfNeeded and friends into V8Initializer.(cpp|h) and share more
code?