[webkit-reviews] review granted: [Bug 100170] Implement AudioBufferSourceNode .loopStart and .loopEnd attributes : [Attachment 171048] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 26 18:51:10 PDT 2012


Kenneth Russell <kbr at google.com> has granted Chris Rogers
<crogers at google.com>'s request for review:
Bug 100170: Implement AudioBufferSourceNode .loopStart and .loopEnd attributes
https://bugs.webkit.org/show_bug.cgi?id=100170

Attachment 171048: Patch
https://bugs.webkit.org/attachment.cgi?id=171048&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=171048&action=review


Very nice. r=me

> LayoutTests/webaudio/audiobuffersource-loop-comprehensive.html:112
> +	   if (expected[j] != renderedData[offsetFrame + j]) {

No epsilon needed in these comparisons?


More information about the webkit-reviews mailing list