[webkit-reviews] review canceled: [Bug 99213] [ARMv7] Neither linkCall() nor linkPointer() should flush code : [Attachment 169195] again

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has canceled Yong Li <yoli at rim.com>'s
request for review:
Bug 99213: [ARMv7] Neither linkCall() nor linkPointer() should flush code
https://bugs.webkit.org/show_bug.cgi?id=99213

Attachment 169195: again
https://bugs.webkit.org/attachment.cgi?id=169195&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=169195&action=review


I remove the review flag for now.
I think this is a nice patch but I would really like it to be completely
generic. ARM is not the only platform without completely consistent caches.

I think we should follow Gavin's advices here. Yong, any opinion?

> Source/JavaScriptCore/ChangeLog:10
> +	   LinkBuffer doesn't need to flush code during linking. It will
> +	   eventually flush the whole executable. Fixing this gives >%5
> +	   sunspider boost (on QNX).

After profiling on hardware, I find it strange you get so much improvement from
this. It is pretty far from a hotspot.

It is still a good idea to fix this though.