[webkit-reviews] review granted: [Bug 98972] [CSS Shaders] Validate types of built-in vertex attributes : [Attachment 169286] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Max Vujovic <mvujovic at adobe.com>'s
request for review:
Bug 98972: [CSS Shaders] Validate types of built-in vertex attributes
https://bugs.webkit.org/show_bug.cgi?id=98972

Attachment 169286: Patch
https://bugs.webkit.org/attachment.cgi?id=169286&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=169286&action=review


> Source/WebCore/platform/graphics/filters/CustomFilterValidatedProgram.cpp:67
> +    for (Vector<ANGLEShaderSymbol>::iterator symbol = symbols.begin();
symbol != symbols.end(); ++symbol) {

In a patch of mine recently, Darin told me that we try to use array indexing
rather than iterators for iterating over Vectors.