[webkit-reviews] review granted: [Bug 98184] HTMLBaseElement href attribute binding returns wrong URL : [Attachment 169416] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Erik Arvidsson <arv at chromium.org>'s
request for review:
Bug 98184: HTMLBaseElement href attribute binding returns wrong URL
https://bugs.webkit.org/show_bug.cgi?id=98184

Attachment 169416: Patch
https://bugs.webkit.org/attachment.cgi?id=169416&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=169416&action=review


>
LayoutTests/fast/dom/HTMLBaseElement/href-attribute-resolves-with-respect-to-do
cument.html:29
> +// Make sure that we don't use the creator document as the base.

Can you add a comment that these three cases should not resolved because nested
document lack a url?