[webkit-reviews] review denied: [Bug 99706] MIPS LLInt implementation. : [Attachment 169392] LLInt implementation for MIPS.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 18 10:52:49 PDT 2012


Filip Pizlo <fpizlo at apple.com> has denied  review:
Bug 99706: MIPS LLInt implementation.
https://bugs.webkit.org/show_bug.cgi?id=99706

Attachment 169392: LLInt implementation for MIPS.
https://bugs.webkit.org/attachment.cgi?id=169392&action=review

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=169392&action=review


> Source/JavaScriptCore/offlineasm/mips.rb:190
> +def mipsLowerBranchOps(list)

Did you copy and paste all of this code?

You should make an effort to reuse code rather than copy and pasting it.


More information about the webkit-reviews mailing list