[webkit-reviews] review granted: [Bug 103410] [Texmap] REGRESSION(r135620) QtTestBrowser crashes on Google-gravity. : [Attachment 176392] Patch : TextureMapperLayerClientQt::setTextureMapper() must call flushCompositingStateForThisLayerOnly() of the root layer.

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam at webkit.org> has granted Huang Dongsung
<luxtella at company100.net>'s request for review:
Bug 103410: [Texmap] REGRESSION(r135620) QtTestBrowser crashes on
Google-gravity.
https://bugs.webkit.org/show_bug.cgi?id=103410

Attachment 176392: Patch : TextureMapperLayerClientQt::setTextureMapper() must
call flushCompositingStateForThisLayerOnly() of the root layer.
https://bugs.webkit.org/attachment.cgi?id=176392&action=review

------- Additional Comments from Noam Rosenthal <noam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=176392&action=review


LGTM with ChangeLog rewording.

> Source/WebKit/qt/ChangeLog:16
> +	   Currently, PageClientQGraphicsWidget::setRootGraphicsLayer does not
flush layer
> +	   states of the root layer after setting TextureMapper while
> +	   PageClientQWidget::setRootGraphicsLayer() flushes them of the root
layer.	If
> +	   not flushing states, descendant layers can not reach the root layer.
It means
> +	   descendant layers can not reach the TextureMapper that the root
layer has.
> +

This is already the behavior for PageClientQWidget, which should be the case
for PageClientQGraphicsWidget as well.