[webkit-reviews] review granted: [Bug 103410] [Texmap] REGRESSION(r135620) QtTestBrowser crashes on Google-gravity. : [Attachment 176391] Patch : GraphicsLayerTextureMapper::updateBackingStore() early returns until TextureMapper is set.

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam at webkit.org> has granted Huang Dongsung
<luxtella at company100.net>'s request for review:
Bug 103410: [Texmap] REGRESSION(r135620) QtTestBrowser crashes on
Google-gravity.
https://bugs.webkit.org/show_bug.cgi?id=103410

Attachment 176391: Patch : GraphicsLayerTextureMapper::updateBackingStore()
early returns until TextureMapper is set.
https://bugs.webkit.org/attachment.cgi?id=176391&action=review

------- Additional Comments from Noam Rosenthal <noam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=176391&action=review


LGTM with changelog rewordings.

> Source/WebCore/ChangeLog:8
> +	   GraphicsLayerTextureMapper::updateBackingStore() early returns until
TextureMapper is set.

early returns until -> should return early before

> Source/WebCore/ChangeLog:12
> +	   TextureMapperLayer::flushCompositingState() checks and early returns
if

returns early

> Source/WebCore/ChangeLog:13
> +	   TextureMapper does not exist.

does not exist -> was not created

> Source/WebCore/ChangeLog:17
> +	   However, GraphicsLayerTextureMapper::updateBackingStore() expects
that TextureMapper
> +	   always exists. This patch makes updateBackingStore() early return
like
> +	   TextureMapperLayer::flushCompositingState().

updateBackingStore should also return early when TextureMapper was not created.