[webkit-reviews] review denied: [Bug 88424] Optimization in image decoding : [Attachment 176379] JPEG part
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Nov 27 23:10:21 PST 2012
Brent Fulgham <bfulgham at webkit.org> has denied Viatcheslav Ostapenko
<ostap73 at gmail.com>'s request for review:
Bug 88424: Optimization in image decoding
https://bugs.webkit.org/show_bug.cgi?id=88424
Attachment 176379: JPEG part
https://bugs.webkit.org/attachment.cgi?id=176379&action=review
------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=176379&action=review
Based on discussion on IRC with ostap and noel, this current patch is missing
some new functionality from the libjpeg-turbo update.
> Source/WebCore/platform/image-decoders/jpeg/JPEGImageDecoder.cpp:652
> + JSAMPLE* jsample = *samples + column * (J_COLOR_SPACE(colorSpace) ==
JCS_CMYK ? 4 : 3);
As Noel pointed out on IRC, this breaks libjpeg-turbo. See
http://trac.webkit.org/browser/trunk/Source/WebCore/platform/image-decoders/jpe
g/JPEGImageDecoder.cpp?annotate=blame&rev=135976#L706 for details of the break.
More specifically:
JSAMPLE* jsample = *samples + (m_scaled ? m_scaledColumns[x] : x) *
((info->out_color_space == JCS_RGB) ? 3 : 4);
> Source/WebCore/platform/image-decoders/jpeg/JPEGImageDecoder.cpp:-706
> - JSAMPLE* jsample = *samples + (m_scaled ? m_scaledColumns[x] :
x) * ((info->out_color_space == JCS_RGB) ? 3 : 4);
This line is not dealt with properly in this change.
More information about the webkit-reviews
mailing list