[webkit-reviews] review canceled: [Bug 79500] [GTK] Add support for window.showModalDialog in WebKit2GTK+ : [Attachment 134057] Patch proposal + Unit tests

[bugzilla-daemon at webkit.org]

Mario Sanchez Prada <msanchez at igalia.com> has canceled Mario Sanchez Prada
<msanchez at igalia.com>'s request for review:
Bug 79500: [GTK] Add support for window.showModalDialog in WebKit2GTK+
https://bugs.webkit.org/show_bug.cgi?id=79500

Attachment 134057: Patch proposal + Unit tests
https://bugs.webkit.org/attachment.cgi?id=134057&action=review

------- Additional Comments from Mario Sanchez Prada <msanchez at igalia.com>
The previous patch got	a bit outdated again, so now attaching a new one that
applies cleanly against today's trunk.

I also made the most of this to re-implement the unit test in a different way,
using a new subclass of UIClientTest (ModalDialogsTest) to avoid adding some
"ifs" to check whether it was a "modal dialogs" test or not.