[webkit-reviews] review granted: [Bug 87263] Web Inspector: add a command to InspectorMemoryAgent for getting process memory break down : [Attachment 143572] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 87263: Web Inspector: add a command to InspectorMemoryAgent for getting
process memory break down
https://bugs.webkit.org/show_bug.cgi?id=87263

Attachment 143572: Patch
https://bugs.webkit.org/attachment.cgi?id=143572&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=143572&action=review


> Source/WebCore/inspector/Inspector.json:95
> +		       { "name": "size", "type": "integer", "description":
"Size of the block in bytes" },

You can't report size for some of the nodes. Should this be optional?

> Source/WebCore/inspector/Inspector.json:96
> +		       { "name": "name", "type": "string", "description":
"User-friendly name describing the component that allocated this block" },

We don't have a way to localize backend. Should this be key names instead?