[webkit-reviews] review requested: [Bug 79500] [GTK] Add support for window.showModalDialog in WebKit2GTK+ : [Attachment 143786] Patch proposal + Unit test
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu May 24 04:46:04 PDT 2012
Mario Sanchez Prada <msanchez at igalia.com> has asked for review:
Bug 79500: [GTK] Add support for window.showModalDialog in WebKit2GTK+
https://bugs.webkit.org/show_bug.cgi?id=79500
Attachment 143786: Patch proposal + Unit test
https://bugs.webkit.org/attachment.cgi?id=143786&action=review
------- Additional Comments from Mario Sanchez Prada <msanchez at igalia.com>
The previous patch got a bit outdated again, so now attaching a new one that
applies cleanly against today's trunk.
I also made the most of this to re-implement the unit test in a different way,
using a new subclass of UIClientTest (ModalDialogsTest) to avoid adding some
"ifs" to check whether it was a "modal dialogs" test or not.
More information about the webkit-reviews
mailing list