[webkit-reviews] review denied: [Bug 85711] Web Inspector: Turn HelpScreen to be View. : [Attachment 140400] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied eustas.bug at gmail.com's request
for review:
Bug 85711: Web Inspector: Turn HelpScreen to be View.
https://bugs.webkit.org/show_bug.cgi?id=85711

Attachment 140400: Patch
https://bugs.webkit.org/attachment.cgi?id=140400&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=140400&action=review


Overall looks good. Note that since you are going to make it tabbed pane, you
will not need the custom show / hide logic - your help screen will become
singleton. So most of the code here will vanish.

> Source/WebCore/inspector/front-end/HelpScreen.js:68
>      show: function(onHide)

Do we actually use onHide?

> Source/WebCore/inspector/front-end/HelpScreen.js:-62
> -	   if (this._isShown)

You are overriding View's show with different parameters. I would pick another
name.

> Source/WebCore/inspector/front-end/HelpScreen.js:70
> +	   var visibleHelpScreen = WebInspector.HelpScreen.visibleScreen_;

_ is before the name, not after

> Source/WebCore/inspector/front-end/HelpScreen.js:79
> +	   WebInspector.View.prototype.show.call(this, document.body);

document.body -> WebInspector.inspectorView.element