[webkit-reviews] review denied: [Bug 85624] Web Inspector: HTMLCanvasElement::didDraw instrumentation. : [Attachment 140392] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied eustas.bug at gmail.com's request
for review:
Bug 85624: Web Inspector: HTMLCanvasElement::didDraw instrumentation.
https://bugs.webkit.org/show_bug.cgi?id=85624

Attachment 140392: Patch
https://bugs.webkit.org/attachment.cgi?id=140392&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=140392&action=review


> Source/WebCore/html/HTMLCanvasElement.cpp:232
> +	   InspectorInstrumentation::didInvalidateCanvasRect(this->document(),
dirtyRect);

simply document()

> Source/WebCore/inspector/TimelineRecordFactory.cpp:196
> +PassRefPtr<InspectorObject>
TimelineRecordFactory::createInvalidateCanvasRectData(const IntRect& rect)

This is just a rect data, you should re-use createPaintData.

> Source/WebCore/inspector/front-end/TimelinePresentationModel.js:519
> +		  
contentHelper._appendTextRow(WebInspector.UIString("Location"),
WebInspector.UIString("(%d, %d)", this.data["x"], this.data["y"]));

Please add corresponding localizedStrings.