[webkit-reviews] review granted: [Bug 85707] Web Inspector: take timeline frame mode out of experimental : [Attachment 140395] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 85707: Web Inspector: take timeline frame mode out of experimental
https://bugs.webkit.org/show_bug.cgi?id=85707

Attachment 140395: Patch
https://bugs.webkit.org/attachment.cgi?id=140395&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=140395&action=review


> Source/WebCore/inspector/InspectorController.cpp:115
> +   
m_agents.append(InspectorTimelineAgent::create(m_instrumentingAgents.get(),
m_state.get(), InspectorTimelineAgent::PageInspector,

You make inspector controller timeline-details-aware. You should instead create
a stub for worker's InspectorClient.