[webkit-reviews] review granted: [Bug 85393] Convert FractionalLayoutUnit overflow assertions to stdout warnings : [Attachment 139903] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 2 16:09:44 PDT 2012


Eric Seidel <eric at webkit.org> has granted Levi Weintraub <leviw at chromium.org>'s
request for review:
Bug 85393: Convert FractionalLayoutUnit overflow assertions to stdout warnings
https://bugs.webkit.org/show_bug.cgi?id=85393

Attachment 139903: Patch
https://bugs.webkit.org/attachment.cgi?id=139903&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
OK.  This seems like the best we've come up with so far.  The big question
remaining is what to do with the tests which now only fail in Debug mode.  If
any of those are ever *supposed* to trigger overflow, they'll now never be able
to pass in both Debug/Release which is bad.  If there exist such tests, then it
seems we'll need to move this back to stderr.


More information about the webkit-reviews mailing list