[webkit-reviews] review granted: [Bug 84317] [chromium] Don't occlude pixels in a surface that are needed for a background filter blur : [Attachment 139905] Patch

[bugzilla-daemon at webkit.org]

Adrienne Walker <enne at google.com> has granted Dana Jansens
<danakj at chromium.org>'s request for review:
Bug 84317: [chromium] Don't occlude pixels in a surface that are needed for a
background filter blur
https://bugs.webkit.org/show_bug.cgi?id=84317

Attachment 139905: Patch
https://bugs.webkit.org/attachment.cgi?id=139905&action=review

------- Additional Comments from Adrienne Walker <enne at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=139905&action=review


R=me, with a few small things to change before landing.  Thanks for all the
iterations.  :)

> Source/WebKit/chromium/tests/CCOcclusionTrackerTest.cpp:2743
> +	   // Make a surface and its replica, each 50x50, that are completely
surrounded by opaque layers which are above them in the z-order.

Not really true here.

> Source/WebKit/chromium/tests/CCOcclusionTrackerTest.cpp:2792
> +	   // Make a surface and its replica, each 50x50, that are completely
surrounded by opaque layers which are above them in the z-order.

s/surrounded/occluded/

> Source/WebKit/chromium/tests/CCOcclusionTrackerTest.cpp:2840
> +	   // Make a surface and its replica, each 50x50, that are completely
surrounded by opaque layers which are above them in the z-order.

s/surrounded/partially occluded/

> Source/WebKit/chromium/tests/CCOcclusionTrackerTest.cpp:2902
> +	   EXPECT_EQ_RECT(occlusionBesideSurface, targetRects[0]);
> +	   EXPECT_EQ_RECT(occlusionBesideSurface, screenRects[0]);
> +	   EXPECT_EQ_RECT(occlusionBesideReplica, targetRects[1]);
> +	   EXPECT_EQ_RECT(occlusionBesideReplica, screenRects[1]);
> +	   EXPECT_EQ_RECT(occlusionAboveSurface, targetRects[2]);
> +	   EXPECT_EQ_RECT(occlusionAboveSurface, screenRects[2]);
> +	   EXPECT_EQ_RECT(occlusionAboveReplica, targetRects[3]);
> +	   EXPECT_EQ_RECT(occlusionAboveReplica, screenRects[3]);

I don't think the ordering of rects in Region is something you should depend
on.  Maybe construct a region yourself with these rects and see if it equals
occlusionInFooSpace?