[webkit-reviews] review requested: [Bug 84317] [chromium] Don't occlude pixels in a surface that are needed for a background filter blur : [Attachment 139905] Patch

[bugzilla-daemon at webkit.org]

Dana Jansens <danakj at chromium.org> has asked  for review:
Bug 84317: [chromium] Don't occlude pixels in a surface that are needed for a
background filter blur
https://bugs.webkit.org/show_bug.cgi?id=84317

Attachment 139905: Patch
https://bugs.webkit.org/attachment.cgi?id=139905&action=review

------- Additional Comments from Dana Jansens <danakj at chromium.org>
The diff got larger due to a small API change on occlusion tracker.

unoccludedContributingSurfaceContentRect(Layer*) became
unoccludedContributingSurfaceContentRect(Surface*).

It used to need the Layer* but Surface* has all the data it needs these days
anyways. This lets us figure out which part of the contributing surface's
background filter will be used, so I can write that unit test you asked for.

There's a huge regex change in the CCOTTest.cpp because of the API change, to
pass in the surface instead of the layer though. Here's the diff minus the
test.cpp http://pastebin.com/iW4Q8bdS

Added 2 new tests. One where the filter is completely occluded, and one where
it is partially occluded.