[webkit-reviews] review granted: [Bug 82321] Add a perf test which updates the value of an already declared CSS property. : [Attachment 134025] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has granted Alexis Menard (darktears)
<alexis.menard at openbossa.org>'s request for review:
Bug 82321: Add a perf test which updates the value of an already declared CSS
property.
https://bugs.webkit.org/show_bug.cgi?id=82321

Attachment 134025: Patch
https://bugs.webkit.org/attachment.cgi?id=134025&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=134025&action=review


r=me

> PerformanceTests/CSS/CSSPropertyUpdateValue.html:77
> +PerfTestRunner.run(function() {
> +    for (key in properties)
> +	   div.style[key] = properties[key];
> +}, 10000);

Would be nice with a comment noting that the first pass is discarded from the
results, since otherwise it looks like one of the passes will add, not update,
properties.