[webkit-reviews] review granted: [Bug 80992] Web Inspector: provide a way to reload page with given script preprocessor. : [Attachment 133848] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Mar 27 04:46:03 PDT 2012
Yury Semikhatsky <yurys at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 80992: Web Inspector: provide a way to reload page with given script
preprocessor.
https://bugs.webkit.org/show_bug.cgi?id=80992
Attachment 133848: Patch
https://bugs.webkit.org/attachment.cgi?id=133848&action=review
------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=133848&action=review
> Source/WebCore/bindings/v8/ScriptDebugServer.cpp:80
> + if (tryCatch.HasCaught())
We should come up with some error reporting mechanism here.
> Source/WebCore/bindings/v8/ScriptDebugServer.cpp:137
> + String m_preprocessorBody;
This field is unused, please remove.
More information about the webkit-reviews
mailing list