[webkit-reviews] review denied: [Bug 80123] [BlackBerry] Upstream LayerAnimation.{cpp, h} : [Attachment 133971] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Mar 27 04:48:57 PDT 2012
Rob Buis <rwlbuis at gmail.com> has denied Robin Cao
<robin.cao at torchmobile.com.cn>'s request for review:
Bug 80123: [BlackBerry] Upstream LayerAnimation.{cpp, h}
https://bugs.webkit.org/show_bug.cgi?id=80123
Attachment 133971: patch
https://bugs.webkit.org/attachment.cgi?id=133971&action=review
------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=133971&action=review
Looks good, but can still be improved a bit.
> Source/WebCore/platform/graphics/blackberry/LayerAnimation.cpp:112
> + ctf->y2(),
These params can be placed in the same line.
> Source/WebCore/platform/graphics/blackberry/LayerAnimation.cpp:221
> + // A trick to avoid touching the refcount of shared
TransformOperations on the wrong thread
Lacks period at end of sentence.
> Source/WebCore/platform/graphics/blackberry/LayerAnimation.h:24
> +#include "GraphicsLayer.h"
Is this one needed?
> Source/WebCore/platform/graphics/blackberry/LayerAnimation.h:50
> +
Remove empty line.
> Source/WebCore/platform/graphics/blackberry/LayerAnimation.h:58
> + // This returns a copy of the animation.
This comment does not add much info.
More information about the webkit-reviews
mailing list